]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
x86/disasm: do not use format string without format specifiers
authorWill Hawkins <hawkinsw@obs.cr>
Sun, 24 May 2026 04:08:24 +0000 (00:08 -0400)
committerH.J. Lu <hjl.tools@gmail.com>
Tue, 26 May 2026 23:56:33 +0000 (07:56 +0800)
Fixes PR binutils/34168: build failure with -Werror=format-security.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34168

Signed-off-by: Will Hawkins <hawkinsw@obs.cr>
opcodes/i386-dis.c

index 3c5f173648a2e819a9972cf29c2c448045d0f0d9..db1e4f7a7d56e7396139da152b48ad94f52b2375 100644 (file)
@@ -10375,7 +10375,7 @@ print_insn (bfd_vma pc, disassemble_info *info, int intel_syntax)
   for (i = 0; i < MAX_OPERANDS; i++)
     if (ins.op_index[i] != -1 && ins.op_riprel[i])
       {
-       i386_dis_printf (info, dis_style_comment_start, sep);
+       i386_dis_printf (info, dis_style_comment_start, "%s", sep);
        sep = ", ";
        (*info->print_address_func)
          ((bfd_vma)(ins.start_pc + (ins.codep - ins.start_codep)
@@ -10384,7 +10384,7 @@ print_insn (bfd_vma pc, disassemble_info *info, int intel_syntax)
       }
     else if (*ins.cm_out[i])
       {
-       i386_dis_printf (info, dis_style_comment_start, sep);
+       i386_dis_printf (info, dis_style_comment_start, "%s", sep);
        sep = ", ";
        i386_dis_printf (info, dis_style_symbol, "%s", ins.cm_out[i]);
       }