]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
locking/rwsem: Use OWNER_NONSPINNABLE directly instead of OWNER_SPINNABLE
authorJinliang Zheng <alexjlzheng@tencent.com>
Tue, 10 Jun 2025 13:01:58 +0000 (21:01 +0800)
committerBoqun Feng <boqun.feng@gmail.com>
Fri, 11 Jul 2025 22:11:54 +0000 (15:11 -0700)
After commit 7d43f1ce9dd0 ("locking/rwsem: Enable time-based spinning on
reader-owned rwsem"), OWNER_SPINNABLE contains all possible values except
OWNER_NONSPINNABLE, namely OWNER_NULL | OWNER_WRITER | OWNER_READER.

Therefore, it is better to use OWNER_NONSPINNABLE directly to determine
whether to exit optimistic spin.

And, remove useless OWNER_SPINNABLE to simplify the code.

Signed-off-by: Jinliang Zheng <alexjlzheng@tencent.com>
Acked-by: Waiman Long <longman@redhat.com>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20250610130158.4876-1-alexjlzheng@tencent.com
kernel/locking/rwsem.c

index 2ddb827e3bea03d36254bb1646c32016d84574d8..8572dba95af4fe28681da659eef9f54b75390696 100644 (file)
@@ -727,8 +727,6 @@ static inline bool rwsem_can_spin_on_owner(struct rw_semaphore *sem)
        return ret;
 }
 
-#define OWNER_SPINNABLE                (OWNER_NULL | OWNER_WRITER | OWNER_READER)
-
 static inline enum owner_state
 rwsem_owner_state(struct task_struct *owner, unsigned long flags)
 {
@@ -835,7 +833,7 @@ static bool rwsem_optimistic_spin(struct rw_semaphore *sem)
                enum owner_state owner_state;
 
                owner_state = rwsem_spin_on_owner(sem);
-               if (!(owner_state & OWNER_SPINNABLE))
+               if (owner_state == OWNER_NONSPINNABLE)
                        break;
 
                /*