]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: xen: scsiback: Fix potential memory leak in scsiback_remove()
authorAbdun Nihaal <nihaal@cse.iitm.ac.in>
Tue, 23 Dec 2025 06:30:11 +0000 (12:00 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 30 Jan 2026 09:27:34 +0000 (10:27 +0100)
commit 901a5f309daba412e2a30364d7ec1492fa11c32c upstream.

Memory allocated for struct vscsiblk_info in scsiback_probe() is not
freed in scsiback_remove() leading to potential memory leaks on remove,
as well as in the scsiback_probe() error paths. Fix that by freeing it
in scsiback_remove().

Cc: stable@vger.kernel.org
Fixes: d9d660f6e562 ("xen-scsiback: Add Xen PV SCSI backend driver")
Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://patch.msgid.link/20251223063012.119035-1-nihaal@cse.iitm.ac.in
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/xen/xen-scsiback.c

index 8b77e4c06e43f8c28b1605f752c7bf208a31950b..3fbea676b3776e0c89115b5d356274e8f75aef1a 100644 (file)
@@ -1262,6 +1262,7 @@ static void scsiback_remove(struct xenbus_device *dev)
        gnttab_page_cache_shrink(&info->free_pages, 0);
 
        dev_set_drvdata(&dev->dev, NULL);
+       kfree(info);
 }
 
 static int scsiback_probe(struct xenbus_device *dev,