]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Fix uninitialized value in QEMU monitor FD sending code
authorDaniel P. Berrange <berrange@redhat.com>
Thu, 30 Jun 2011 14:04:23 +0000 (15:04 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Thu, 30 Jun 2011 17:04:02 +0000 (18:04 +0100)
The 'char control[CMSG_SPACE(sizeof(int))];' was not being
wiped, so could potentially contain uninitialized bytes.
While this was harmless in this case, it caused complaints
from valgrind

* src/qemu/qemu_monitor.c: memset 'control' variable
  in qemuMonitorIOWriteWithFD

src/qemu/qemu_monitor.c

index e995d978148f1dd6b5ef4a460a0817f1797f2e5f..85732621a5b05a5620b20bee576cee825eb626d6 100644 (file)
@@ -383,6 +383,7 @@ qemuMonitorIOWriteWithFD(qemuMonitorPtr mon,
     struct cmsghdr *cmsg;
 
     memset(&msg, 0, sizeof(msg));
+    memset(control, 0, sizeof(control));
 
     iov[0].iov_base = (void *)data;
     iov[0].iov_len = len;