fetch: fix wrong evaluation order in URL trailing-slash trimming

if i == -1, url[i] will be UB.

Signed-off-by: cuiweixie <cuiweixie@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/fetch.c b/builtin/fetch.c
index 40a0e8d24434f2f4fc5b92a3411cce96ccf70e83..1ced5f22de26af36eed4627973970e0b30155eb9 100644 (file)
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -761,7 +761,7 @@ static void display_state_init(struct display_state *display_state, struct ref *
                display_state->url = xstrdup("foreign");
 
        display_state->url_len = strlen(display_state->url);
-       for (i = display_state->url_len - 1; display_state->url[i] == '/' && 0 <= i; i--)
+       for (i = display_state->url_len - 1; 0 <= i && display_state->url[i] == '/'; i--)
                ;
        display_state->url_len = i + 1;
        if (4 < i && !strncmp(".git", display_state->url + i - 3, 4))