]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
CLEANUP: qpack: fix format string in debugging code (int signedness)
authorWilly Tarreau <w@1wt.eu>
Thu, 24 Nov 2022 14:35:17 +0000 (15:35 +0100)
committerWilly Tarreau <w@1wt.eu>
Thu, 24 Nov 2022 14:35:17 +0000 (15:35 +0100)
In issue #1939, Ilya mentions that cppchecks warned about use of "%d" to
report the QPACK table's index that's locally stored as an unsigned int.
While technically valid, this will never cause any trouble since indexes
are always small positive values, but better use %u anyway to silence
this warning.

src/qpack-tbl.c

index 6713f6dd399312b9aa62b94bca277985bcc7eae7..09f01157f2c1e85b5a5f18dbfde821e711d056fa 100644 (file)
@@ -154,7 +154,7 @@ void qpack_dht_dump(FILE *out, const struct qpack_dht *dht)
 
        for (i = HPACK_SHT_SIZE; i < HPACK_SHT_SIZE + dht->used; i++) {
                slot = (qpack_get_dte(dht, i - HPACK_SHT_SIZE + 1) - dht->dte);
-               fprintf(out, "idx=%d slot=%u name=<%s> value=<%s> addr=%u-%u\n",
+               fprintf(out, "idx=%u slot=%u name=<%s> value=<%s> addr=%u-%u\n",
                        i, slot,
                        istpad(name, qpack_idx_to_name(dht, i)).ptr,
                        istpad(value, qpack_idx_to_value(dht, i)).ptr,