iplink: Process "alias" parameter correctly

Do not stop parameters processing after "alias" parameter: it might
not be a last one. Seems copy pasted from "type" parameter code.

Check it's length does not exceed IFALIASZ - 1. Better we warn
than get RTNL error.

Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

diff --git a/ip/iplink.c b/ip/iplink.c
index 4f9c169a790e920441c074765510c3ec27b6bc5d..4c967112460aaeeb4100922af5405c61ed8ebc9e 100644 (file)
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -770,11 +770,12 @@ int iplink_parse(int argc, char **argv, struct iplink_req *req,
                        argc--; argv++;
                        break;
                } else if (matches(*argv, "alias") == 0) {
+                       len = strlen(*argv);
+                       if (len >= IFALIASZ)
+                               invarg("alias too long\n", *argv);
                        NEXT_ARG();
                        addattr_l(&req->n, sizeof(*req), IFLA_IFALIAS,
-                                 *argv, strlen(*argv));
-                       argc--; argv++;
-                       break;
+                                 *argv, len);
                } else if (strcmp(*argv, "group") == 0) {
                        NEXT_ARG();
                        if (*group != -1)