]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commitdiff
patchtest-send-results: Add 'References' header
authorTrevor Gamblin <tgamblin@baylibre.com>
Fri, 9 Feb 2024 14:30:41 +0000 (09:30 -0500)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 10 Feb 2024 14:12:54 +0000 (14:12 +0000)
Based on https://www.rfc-editor.org/rfc/rfc2822#section-3.6.4, to get
proper threading there should be a 'References' field defined in
Patchtest's response headers if its replies are going to thread properly
on Patchwork. This wasn't there before, hence why were were seeing the
responses in the right place on the mailing list but not Patchwork.

Since we only want Patchtest to reply directly to the tested patch,
the 'References' field should only need to contain the same ID as the
'In-Reply-To' one.

Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
scripts/patchtest-send-results

index 075b60d8f7d513f0f2db635b267d2a4caebf8d39..9fd24c9b959d438f808908cc80009d35475a41f1 100755 (executable)
@@ -81,9 +81,14 @@ if has_a_failed_test(testresult):
         reply_contents = greeting + testresult + suggestions
 
     ses_client = boto3.client('ses', region_name='us-west-2')
+
+    # Construct the headers for the email. We only want to reply
+    # directly to the tested patch, so make In-Reply-To and References
+    # the same value.
     raw_data = 'From: ' + from_address + '\nTo: ' + reply_address + \
         '\nCC: ' + cc_address + '\nSubject:' + subject_line + \
         '\nIn-Reply-To:' + in_reply_to + \
+        '\nReferences:' + in_reply_to + \
         '\nMIME-Version: 1.0" + \
         "\nContent-type: Multipart/Mixed;boundary="NextPart"\n\n--NextPart\nContent-Type: text/plain\n\n' + \
         reply_contents + '\n\n--NextPart'