]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: SOF: ipc4-control: Set correct error code in refresh_bytes_control
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Mon, 9 Feb 2026 12:02:39 +0000 (14:02 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 9 Feb 2026 12:27:28 +0000 (12:27 +0000)
Return -EINVAL in case the scontrol contains more data than the amount of
space available for it to store in sof_ipc4_refresh_bytes_control().

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-sound/aYXvFr-LVHVJSvS7@stanley.mountain/
Fixes: 2a28b5240f2b ("ASoC: SOF: ipc4-control: Add support for generic bytes control")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://patch.msgid.link/20260209120239.6066-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/ipc4-control.c

index 0500b690f9a33486cb21cfa48a6c22533adc8572..596c3d77a34e18e100f6a611b46315af0720d864 100644 (file)
@@ -362,6 +362,7 @@ sof_ipc4_refresh_bytes_control(struct snd_sof_control *scontrol, bool lock)
                                "%s: no space for data in %s (%zu, %zu)\n",
                                __func__, scontrol->name, msg->data_size,
                                scontrol->max_size - sizeof(*data));
+                       ret = -EINVAL;
                        goto out;
                }