]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ext4: move the calculation of wbc->nr_to_write to mpage_folio_done()
authorZhang Yi <yi.zhang@huawei.com>
Mon, 7 Jul 2025 14:08:05 +0000 (22:08 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 14 Jul 2025 03:41:51 +0000 (23:41 -0400)
mpage_folio_done() should be a more appropriate place than
mpage_submit_folio() for updating the wbc->nr_to_write after we have
submitted a fully mapped folio. Preparing to make mpage_submit_folio()
allows to submit partially mapped folio that is still under processing.

Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Baokun Li <libaokun1@huawei.com>
Link: https://patch.msgid.link/20250707140814.542883-3-yi.zhang@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/inode.c

index 4cb499f28c12c427de663a2828a725a25cd6d80b..399c765bc22dd687de344b9e2d19a770db6b0dbd 100644 (file)
@@ -2024,6 +2024,7 @@ int ext4_da_get_block_prep(struct inode *inode, sector_t iblock,
 static void mpage_folio_done(struct mpage_da_data *mpd, struct folio *folio)
 {
        mpd->start_pos += folio_size(folio);
+       mpd->wbc->nr_to_write -= folio_nr_pages(folio);
        folio_unlock(folio);
 }
 
@@ -2054,8 +2055,6 @@ static int mpage_submit_folio(struct mpage_da_data *mpd, struct folio *folio)
            !ext4_verity_in_progress(mpd->inode))
                len = size & (len - 1);
        err = ext4_bio_write_folio(&mpd->io_submit, folio, len);
-       if (!err)
-               mpd->wbc->nr_to_write -= folio_nr_pages(folio);
 
        return err;
 }