]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
bdev: Drop pointless invalidate_inode_buffers() call
authorJan Kara <jack@suse.cz>
Thu, 26 Mar 2026 09:53:59 +0000 (10:53 +0100)
committerChristian Brauner <brauner@kernel.org>
Thu, 26 Mar 2026 14:03:27 +0000 (15:03 +0100)
Nobody is calling mark_buffer_dirty_inode() with internal bdev inode and
it doesn't make sense for internal bdev inode to have any metadata
buffer heads. Just drop the pointless invalidate_inode_buffers() call
and consequently the whole bdev_evict_inode() because generic code takes
care of the rest.

CC: linux-block@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20260326095354.16340-47-jack@suse.cz
Signed-off-by: Christian Brauner <brauner@kernel.org>
block/bdev.c

index ed022f8c48c79c09735ab7bf019629a25bd91f72..bb0ffa3bb4dfbf6624aa777bfa45c694380bfef1 100644 (file)
@@ -417,19 +417,11 @@ static void init_once(void *data)
        inode_init_once(&ei->vfs_inode);
 }
 
-static void bdev_evict_inode(struct inode *inode)
-{
-       truncate_inode_pages_final(&inode->i_data);
-       invalidate_inode_buffers(inode); /* is it needed here? */
-       clear_inode(inode);
-}
-
 static const struct super_operations bdev_sops = {
        .statfs = simple_statfs,
        .alloc_inode = bdev_alloc_inode,
        .free_inode = bdev_free_inode,
        .drop_inode = inode_just_drop,
-       .evict_inode = bdev_evict_inode,
 };
 
 static int bd_init_fs_context(struct fs_context *fc)