]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
gpo: Improve debug when extension fails to apply
authorDavid Mulder <dmulder@suse.com>
Mon, 19 Jul 2021 17:36:09 +0000 (11:36 -0600)
committerJeremy Allison <jra@samba.org>
Tue, 20 Jul 2021 15:25:37 +0000 (15:25 +0000)
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
python/samba/gpclass.py

index 6879719847f93cbf282adfe4001fd221dde3f2f4..17d7d0c9243b2b514cd9de4427e32405cccc3c3e 100644 (file)
@@ -23,6 +23,7 @@ sys.path.insert(0, "bin/python")
 from samba import NTSTATUSError
 from configparser import ConfigParser
 from io import StringIO
+import traceback
 from samba.common import get_bytes
 from abc import ABCMeta, abstractmethod
 import xml.etree.ElementTree as etree
@@ -467,7 +468,8 @@ def apply_gp(lp, creds, logger, store, gp_extensions, force=False):
             ext.process_group_policy(del_gpos, changed_gpos)
         except Exception as e:
             logger.error('Failed to apply extension  %s' % str(ext))
-            logger.error('Message was: ' + str(e))
+            logger.error('Message was: %s: %s' % (type(e).__name__, str(e)))
+            logger.debug(traceback.format_exc())
             continue
     for gpo_obj in gpos:
         if not gpo_obj.file_sys_path: