]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuBuildMemoryDeviceStr: check return of qemuBuildDeviceAddressStr
authorJán Tomko <jtomko@redhat.com>
Thu, 10 Dec 2020 08:49:07 +0000 (09:49 +0100)
committerJán Tomko <jtomko@redhat.com>
Thu, 10 Dec 2020 11:58:54 +0000 (12:58 +0100)
Although the function currently only returns errors for PCI addresses,
check it here too, in case that changes in the future.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_command.c

index 76edc3c617583c7739ccbed1218507fe62762aa1..b06a086e18012121c3b4638b494dd2deef2eccdc 100644 (file)
@@ -3317,7 +3317,8 @@ qemuBuildMemoryDeviceStr(const virDomainDef *def,
         virBufferAsprintf(&buf, "memdev=mem%s,id=%s",
                           mem->info.alias, mem->info.alias);
 
-        qemuBuildDeviceAddressStr(&buf, def, &mem->info, qemuCaps);
+        if (qemuBuildDeviceAddressStr(&buf, def, &mem->info, qemuCaps) < 0)
+            return NULL;
         break;
 
     case VIR_DOMAIN_MEMORY_MODEL_NONE: