Mark TODO on icap_access with authentication

icap_access curently treats AUTH_REQUIRED ACL results as a
false-negative 'fail' result. This is not the desired behavior,
but is not bad enough to be treated as an actual bug at this point.

diff --git a/src/adaptation/AccessCheck.cc b/src/adaptation/AccessCheck.cc
index 870f610e778d6922c812b9277253bb3e4df8de7c..db3586186c89b70a7b112ded6d61213b7731ea09 100644 (file)
--- a/src/adaptation/AccessCheck.cc
+++ b/src/adaptation/AccessCheck.cc
@@ -123,6 +123,11 @@ Adaptation::AccessCheck::AccessCheckCallbackWrapper(int answer, void *data)
 {
     debugs(93, 8, "AccessCheckCallbackWrapper: answer=" << answer);
     AccessCheck *ac = (AccessCheck*)data;
+
+    /** \todo AYJ 2008-06-12: If answer == ACCESS_REQ_PROXY_AUTH
+     * we should be kicking off an authentication before continuing
+     * with this request. see bug 2400 for details.
+     */
     ac->noteAnswer(answer==ACCESS_ALLOWED);
 }