]> git.ipfire.org Git - thirdparty/bootstrap.git/commitdiff
avoid console call in our unit tests (#27790)
authorJohann-S <johann.servoire@gmail.com>
Thu, 6 Dec 2018 08:51:35 +0000 (09:51 +0100)
committerXhmikosR <xhmikosr@gmail.com>
Thu, 6 Dec 2018 08:51:35 +0000 (10:51 +0200)
js/tests/unit/.eslintrc.json
js/tests/unit/tooltip.js
js/tests/unit/util.js

index 7a3b99ead0fa6d9852814fe9b64757a47824c45c..86d851ad06d0aa8bc7c37f92aef102a01bae95b9 100644 (file)
@@ -20,7 +20,7 @@
   },
   "extends": "../../../.eslintrc.json",
   "rules": {
-    "no-console": "off",
+    "no-console": "error",
     // Best Practices
     "consistent-return": "off",
     "no-magic-numbers": "off",
index 289f8aebff512e2e4b60653deaa72b780127a808..54dbe57bd86b20eb5badad2224bc7f3c9dd50777 100644 (file)
@@ -563,7 +563,6 @@ $(function () {
       $tooltip.bootstrapTooltip('show')
     } catch (err) {
       passed = false
-      console.log(err)
     }
 
     assert.ok(passed, '.tooltip(\'show\') should not throw an error if element no longer is in dom')
index 2fd6f6b7cb52bb670f57236f17bf85248ce687be..cb938314330bc1126e4733360a389ada9bb55e81 100644 (file)
@@ -137,7 +137,6 @@ $(function () {
     var shadowRoot = $div[0].attachShadow({
       mode: 'open'
     })
-    console.warn($div[0].attachShadow, shadowRoot)
 
     assert.equal(shadowRoot, Util.findShadowRoot(shadowRoot))
     shadowRoot.innerHTML = '<button>Shadow Button</button>'