]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: usb: sr9700: fix incorrect command used to write single register
authorEthan Nelson-Moore <enelsonmoore@gmail.com>
Sun, 21 Dec 2025 08:24:00 +0000 (00:24 -0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 30 Dec 2025 09:31:54 +0000 (10:31 +0100)
This fixes the device failing to initialize with "error reading MAC
address" for me, probably because the incorrect write of NCR_RST to
SR_NCR is not actually resetting the device.

Fixes: c9b37458e95629b1d1171457afdcc1bf1eb7881d ("USB2NET : SR9700 : One chip USB 1.1 USB2NET SR9700Device Driver Support")
Cc: stable@vger.kernel.org
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Link: https://patch.msgid.link/20251221082400.50688-1-enelsonmoore@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/usb/sr9700.c

index d8ffb59eaf348850186bb7d2595ba3b743b7046e..820c4c50697921c59c6466387c21e54bdb334ea9 100644 (file)
@@ -52,7 +52,7 @@ static int sr_read_reg(struct usbnet *dev, u8 reg, u8 *value)
 
 static int sr_write_reg(struct usbnet *dev, u8 reg, u8 value)
 {
-       return usbnet_write_cmd(dev, SR_WR_REGS, SR_REQ_WR_REG,
+       return usbnet_write_cmd(dev, SR_WR_REG, SR_REQ_WR_REG,
                                value, reg, NULL, 0);
 }
 
@@ -65,7 +65,7 @@ static void sr_write_async(struct usbnet *dev, u8 reg, u16 length,
 
 static void sr_write_reg_async(struct usbnet *dev, u8 reg, u8 value)
 {
-       usbnet_write_cmd_async(dev, SR_WR_REGS, SR_REQ_WR_REG,
+       usbnet_write_cmd_async(dev, SR_WR_REG, SR_REQ_WR_REG,
                               value, reg, NULL, 0);
 }