2007-07-18 Havoc Pennington <hp@redhat.com>

	* dbus/dbus-message.c (dbus_message_get_cached)
	(dbus_message_cache_or_finalize): don't mess with message from
	message cache outside of the cache lock. Bug #9164 from Jonathan
	Matthew.

diff --git a/ChangeLog b/ChangeLog
index d3c200414a6090361508199cd6dc84e0d43da8fd..a744539a1612d748f555158a1ae58fd7c5f03bb1 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2007-07-18  Havoc Pennington  <hp@redhat.com>
+
+       * dbus/dbus-message.c (dbus_message_get_cached)
+       (dbus_message_cache_or_finalize): don't mess with message from
+       message cache outside of the cache lock. Bug #9164 from Jonathan
+       Matthew.
+
 2007-07-10  Havoc Pennington  <hp@redhat.com>
 
        * dbus/dbus-connection.c (struct DBusConnection): Fix from Olivier

diff --git a/dbus/dbus-message.c b/dbus/dbus-message.c
index 983543daa5bf9b211290678a6d4e61435ce8cb02..31869cb730139a5b15ea7654580e18ca24317e63 100644 (file)
--- a/dbus/dbus-message.c
+++ b/dbus/dbus-message.c
@@ -482,10 +482,10 @@ dbus_message_get_cached (void)
   _dbus_assert (i < MAX_MESSAGE_CACHE_SIZE);
   _dbus_assert (message != NULL);
 
-  _DBUS_UNLOCK (message_cache);
-
   _dbus_assert (message->refcount.value == 0);
   _dbus_assert (message->size_counters == NULL);
+  
+  _DBUS_UNLOCK (message_cache);
 
   return message;
 }
@@ -571,10 +571,10 @@ dbus_message_cache_or_finalize (DBusMessage *message)
 #endif
 
  out:
-  _DBUS_UNLOCK (message_cache);
-
   _dbus_assert (message->refcount.value == 0);
   
+  _DBUS_UNLOCK (message_cache);
+  
   if (!was_cached)
     dbus_message_finalize (message);
 }