and this comment

diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py
index d245c781a3490ad17caaf3c886a595bf2e8ee045..2024666b632363eb9596915d699526cf825962f7 100644 (file)
--- a/lib/sqlalchemy/sql/compiler.py
+++ b/lib/sqlalchemy/sql/compiler.py
@@ -1087,6 +1087,10 @@ class SQLCompiler(engine.Compiled):
         cloned = {}
         column_translate = [{}]
 
+        # TODO: should we be using isinstance() for this,
+        # as this whole system won't work for custom Join/Select
+        # subclasses where compilation routines
+        # call down to compiler.visit_join(), compiler.visit_select()
         join_name = sql.Join.__visit_name__
         select_name = sql.Select.__visit_name__