]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: fsl-asoc-card: Use of_property_present() for non-boolean properties
authorChancel Liu <chancel.liu@nxp.com>
Tue, 16 Dec 2025 07:16:56 +0000 (16:16 +0900)
committerMark Brown <broonie@kernel.org>
Wed, 17 Dec 2025 12:01:03 +0000 (12:01 +0000)
The use of of_property_read_bool() for non-boolean properties is
deprecated in favor of of_property_present() when testing for property
presence.
Otherwise there'll be kernel warning:
[   29.018081] OF: /sound-wm8962: Read of boolean property 'hp-det-gpios' with a value.

Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
Link: https://patch.msgid.link/20251216071656.648412-1-chancel.liu@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/fsl-asoc-card.c

index 2c7eb0baa0f361b7d34ad84400489bcd6ed19b70..70a6159430ed39dc81ac78fa881a94eada7351ff 100644 (file)
@@ -1045,8 +1045,8 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
         * The notifier is initialized in snd_soc_card_jack_new(), then
         * snd_soc_jack_notifier_register can be called.
         */
-       if (of_property_read_bool(np, "hp-det-gpios") ||
-           of_property_read_bool(np, "hp-det-gpio") /* deprecated */) {
+       if (of_property_present(np, "hp-det-gpios") ||
+           of_property_present(np, "hp-det-gpio") /* deprecated */) {
                ret = simple_util_init_jack(&priv->card, &priv->hp_jack,
                                            1, NULL, "Headphone Jack");
                if (ret)
@@ -1055,8 +1055,8 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
                snd_soc_jack_notifier_register(&priv->hp_jack.jack, &hp_jack_nb);
        }
 
-       if (of_property_read_bool(np, "mic-det-gpios") ||
-           of_property_read_bool(np, "mic-det-gpio") /* deprecated */) {
+       if (of_property_present(np, "mic-det-gpios") ||
+           of_property_present(np, "mic-det-gpio") /* deprecated */) {
                ret = simple_util_init_jack(&priv->card, &priv->mic_jack,
                                            0, NULL, "Mic Jack");
                if (ret)