]> git.ipfire.org Git - thirdparty/google/fonts.git/commitdiff
Relax uniqueness criteria to "unique within a script"
authorSimon Cozens <simon@simon-cozens.org>
Wed, 15 May 2024 13:53:11 +0000 (14:53 +0100)
committerSimon Cozens <simon@simon-cozens.org>
Wed, 15 May 2024 13:53:11 +0000 (14:53 +0100)
tests/test_data_languages.py

index 3a8ef6b6e5b54750795e38e924fddad98ee90e0a..25a22dd3c4ea22f2511bb7c3d76c7b6a906530eb 100644 (file)
@@ -268,7 +268,15 @@ def test_exemplar_parser():
 
 
 def test_language_uniqueness():
-    names = Counter([lang.name for lang in LANGUAGES.values()])
+    names = Counter([])
+    for lang in LANGUAGES.values():
+        # We check that names are unique *within a script* since
+        # when we display them in a menu we segment that menu by
+        # script and then by language
+        if lang.preferred_name:
+            names[lang.script + "/" + lang.preferred_name] += 1
+        else:
+            names[lang.name + "/" + lang.preferred_name] += 1
     if any(count > 1 for count in names.values()):
         duplicates = {name: count for name, count in names.items() if count > 1}
         pytest.fail(f"Duplicate language names: {duplicates}")