]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
USB: serial: Fix memory leak in sierra_release()
authorLennart Sorensen <lsorense@csclub.uwaterloo.ca>
Wed, 24 Oct 2012 14:23:09 +0000 (10:23 -0400)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Mon, 10 Feb 2014 21:11:20 +0000 (16:11 -0500)
commit f7bc5051667b74c3861f79eed98c60d5c3b883f7 upstream.

I found a memory leak in sierra_release() (well sierra_probe() I guess)
that looses 8 bytes each time the driver releases a device.

Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca>
Acked-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
drivers/usb/serial/sierra.c

index e3f32a41ef34efed11a233d889c1fdd4981ed6a1..42ea133b0d576e2caa18b5a3e1308094459c7cc6 100644 (file)
@@ -980,6 +980,7 @@ static void sierra_release(struct usb_serial *serial)
                        continue;
                kfree(portdata);
        }
+       kfree(serial->private);
 }
 
 #ifdef CONFIG_PM