auth4: Save lines with talloc_asprintf_addbuf() in authsam_domain_group_filter()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source4/auth/sam.c b/source4/auth/sam.c
index f2e5ced6caf84e7b5d055bba3476f217e88ffdb5..2b18d4dc3c019d1dee9db26d5b5564cb0ba50995 100644 (file)
--- a/source4/auth/sam.c
+++ b/source4/auth/sam.c
@@ -310,25 +310,19 @@ static NTSTATUS authsam_domain_group_filter(TALLOC_CTX *mem_ctx,
        *_filter = NULL;
 
        filter = talloc_strdup(mem_ctx, "(&(objectClass=group)");
-       if (filter == NULL) {
-               return NT_STATUS_NO_MEMORY;
-       }
 
        /*
         * Skip all builtin groups, they're added later.
         */
-       filter = talloc_asprintf_append_buffer(filter,
-                               "(!(groupType:1.2.840.113556.1.4.803:=%u))",
-                               GROUP_TYPE_BUILTIN_LOCAL_GROUP);
-       if (filter == NULL) {
-               return NT_STATUS_NO_MEMORY;
-       }
+       talloc_asprintf_addbuf(&filter,
+                              "(!(groupType:1.2.840.113556.1.4.803:=%u))",
+                              GROUP_TYPE_BUILTIN_LOCAL_GROUP);
        /*
         * Only include security groups.
         */
-       filter = talloc_asprintf_append_buffer(filter,
-                               "(groupType:1.2.840.113556.1.4.803:=%u))",
-                               GROUP_TYPE_SECURITY_ENABLED);
+       talloc_asprintf_addbuf(&filter,
+                              "(groupType:1.2.840.113556.1.4.803:=%u))",
+                              GROUP_TYPE_SECURITY_ENABLED);
        if (filter == NULL) {
                return NT_STATUS_NO_MEMORY;
        }