]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-134584: Fix _CALL_BUILTIN_O test to reflect real-world usage (GH-143333)
authorKen Jin <kenjin@python.org>
Thu, 1 Jan 2026 18:54:49 +0000 (02:54 +0800)
committerGitHub <noreply@github.com>
Thu, 1 Jan 2026 18:54:49 +0000 (18:54 +0000)
Fix test to reflect real-world usage

Lib/test/test_capi/test_opt.py

index bb4aa6ff113f4766c9744939f53a6f67731c3772..bff97fe8320b22fd79c2c2c209bd2234f6cba200 100644 (file)
@@ -2201,8 +2201,7 @@ class TestUopsOptimization(unittest.TestCase):
         def testfunc(n):
             x = 0
             for _ in range(n):
-                my_abs = abs
-                y = my_abs(1)
+                y = abs(1)
                 x += y
             return x
 
@@ -2210,9 +2209,10 @@ class TestUopsOptimization(unittest.TestCase):
         self.assertEqual(res, TIER2_THRESHOLD)
         self.assertIsNotNone(ex)
         uops = get_opnames(ex)
+        pop_tops = [opname for opname in iter_opnames(ex) if opname == "_POP_TOP"]
         self.assertIn("_CALL_BUILTIN_O", uops)
-        self.assertNotIn("_POP_TOP", uops)
         self.assertIn("_POP_TOP_NOP", uops)
+        self.assertLessEqual(len(pop_tops), 1)
 
     def test_call_method_descriptor_o(self):
         def testfunc(n):