]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
- clean up some of the requires for cross-schema reflection
authorMike Bayer <mike_mp@zzzcomputing.com>
Mon, 3 Jun 2013 22:11:32 +0000 (18:11 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Tue, 2 Jul 2013 23:12:49 +0000 (19:12 -0400)
- add oracle profile counts

test/engine/test_reflection.py
test/requirements.py

index 066dbf0b3e9c9cedaac3fffdb1a0e84eb2867683..c490efff2cb77d99ba119c3a778759f05bbb1099 100644 (file)
@@ -1144,15 +1144,13 @@ class UnicodeReflectionTest(fixtures.TestBase):
 class SchemaTest(fixtures.TestBase):
 
     @testing.requires.schemas
-    @testing.fails_on_everything_except("postgresql", "unimplemented feature")
+    @testing.requires.cross_schema_fk_reflection
     def test_has_schema(self):
         eq_(testing.db.dialect.has_schema(testing.db, 'test_schema'), True)
         eq_(testing.db.dialect.has_schema(testing.db, 'sa_fake_schema_123'), False)
 
-    @testing.crashes('firebird', 'No schema support')
+    @testing.requires.schemas
     @testing.fails_on('sqlite', 'FIXME: unknown')
-    # fixme: revisit these below.
-    @testing.fails_on('access', 'FIXME: unknown')
     @testing.fails_on('sybase', 'FIXME: unknown')
     def test_explicit_default_schema(self):
         engine = testing.db
@@ -1191,9 +1189,7 @@ class SchemaTest(fixtures.TestBase):
         finally:
             metadata.drop_all()
 
-    @testing.crashes('firebird', 'No schema support')
-    # fixme: revisit these below.
-    @testing.fails_on('access', 'FIXME: unknown')
+    @testing.requires.schemas
     @testing.fails_on('sybase', 'FIXME: unknown')
     def test_explicit_default_schema_metadata(self):
         engine = testing.db
@@ -1244,6 +1240,7 @@ class SchemaTest(fixtures.TestBase):
         )
 
     @testing.requires.schemas
+    @testing.requires.cross_schema_fk_reflection
     @testing.provide_metadata
     def test_reflect_all_schemas_default_overlap(self):
         t1 = Table('t', self.metadata,
index 807f21baca58ebd3f1e8f5d8688e93cac89b3ea5..fd3678eb52eda4590d9f05eaf908697e5e665662 100644 (file)
@@ -240,6 +240,13 @@ class DefaultRequirements(SuiteRequirements):
                     "firebird"
                 ], "no schema support")
 
+    @property
+    def cross_schema_fk_reflection(self):
+        """target system must support reflection of inter-schema foreign keys
+        """
+        return only_on([
+                    "postgresql"
+                ])
 
     @property
     def update_nowait(self):