]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
validate: refactor - remove check for impossible return values
authorTomas Krizek <tomas.krizek@nic.cz>
Mon, 1 Nov 2021 14:39:04 +0000 (15:39 +0100)
committerTomas Krizek <tomas.krizek@nic.cz>
Tue, 21 Dec 2021 14:02:08 +0000 (15:02 +0100)
kr_dnskeys_trusted() only returns EINVAL, ENOENT or EOK.

lib/layer/validate.c

index db3c0c78cab4dd0350d3aebeae7a87924a7ece7f..da9d0e676c77167c5c6fe796773584ba000b7e53 100644 (file)
@@ -385,10 +385,7 @@ static int validate_keyset(struct kr_request *req, knot_pkt_t *answer, bool has_
                                ret == 0 ? KR_RANK_SECURE : KR_RANK_BOGUS);
 
                if (ret != 0) {
-                       if (ret != kr_error(DNSSEC_INVALID_DS_ALGORITHM) &&
-                           ret != kr_error(EAGAIN)) {
-                               log_bogus_rrsig(&vctx, qry->zone_cut.key, "bogus key");
-                       }
+                       log_bogus_rrsig(&vctx, qry->zone_cut.key, "bogus key");
                        knot_rrset_free(qry->zone_cut.key, qry->zone_cut.pool);
                        qry->zone_cut.key = NULL;
                        return ret;