]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drivers/i2c/busses: use min() instead of min_t()
authorDavid Laight <david.laight.linux@gmail.com>
Wed, 19 Nov 2025 22:41:16 +0000 (22:41 +0000)
committerAndi Shyti <andi.shyti@kernel.org>
Tue, 20 Jan 2026 13:14:36 +0000 (14:14 +0100)
min_t(u8, a, b) casts both its arguments to u8 potentially discarding
signifinact bits.
Use min(a, b) instead as it cannot discard significant bits.

Detected by an extra check added to min_t().

Signed-off-by: David Laight <david.laight.linux@gmail.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20251119224140.8616-21-david.laight.linux@gmail.com
drivers/i2c/busses/i2c-designware-master.c

index 15b3a46f01322ab635762d9e21759c4ef8da5c92..18f9a587732cff493207fc402afb61db792288dd 100644 (file)
@@ -575,7 +575,7 @@ i2c_dw_recv_len(struct dw_i2c_dev *dev, u8 len)
         * after receiving the first byte.
         */
        len += (flags & I2C_CLIENT_PEC) ? 2 : 1;
-       dev->tx_buf_len = len - min_t(u8, len, dev->rx_outstanding);
+       dev->tx_buf_len = len - min(len, dev->rx_outstanding);
        msgs[dev->msg_read_idx].len = len;
        msgs[dev->msg_read_idx].flags &= ~I2C_M_RECV_LEN;