i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c

Remove debug macros and printk and dev_dbg function calls from file
as no change was done for long time.
Remove i2c_debug module parameter also as its implementation, the debug
macros, has been removed.

Signed-off-by: Cezar Chiru <chiru.cezar.89@gmail.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20251018091258.5266-2-chiru.cezar.89@gmail.com

diff --git a/drivers/i2c/algos/i2c-algo-pcf.c b/drivers/i2c/algos/i2c-algo-pcf.c
index fd563e845d4b70493df0ab561db84dec9b54e00f..7e2d8ff33d75e9542cfaaaa95b11ba0f7e5c0c19 100644 (file)
--- a/drivers/i2c/algos/i2c-algo-pcf.c
+++ b/drivers/i2c/algos/i2c-algo-pcf.c
@@ -23,17 +23,8 @@
 #include "i2c-algo-pcf.h"
 
 
-#define DEB2(x) if (i2c_debug >= 2) x
-#define DEB3(x) if (i2c_debug >= 3) x /* print several statistical values */
-#define DEBPROTO(x) if (i2c_debug >= 9) x;
-       /* debug the protocol by showing transferred bits */
 #define DEF_TIMEOUT 16
 
-/*
- * module parameters:
- */
-static int i2c_debug;
-
 /* setting states on the bus with the right timing: */
 
 #define set_pcf(adap, ctl, val) adap->setpcf(adap->data, ctl, val)
@@ -47,27 +38,21 @@ static int i2c_debug;
 
 static void i2c_start(struct i2c_algo_pcf_data *adap)
 {
-       DEBPROTO(printk(KERN_DEBUG "S "));
        set_pcf(adap, 1, I2C_PCF_START);
 }
 
 static void i2c_repstart(struct i2c_algo_pcf_data *adap)
 {
-       DEBPROTO(printk(" Sr "));
        set_pcf(adap, 1, I2C_PCF_REPSTART);
 }
 
 static void i2c_stop(struct i2c_algo_pcf_data *adap)
 {
-       DEBPROTO(printk("P\n"));
        set_pcf(adap, 1, I2C_PCF_STOP);
 }
 
 static void handle_lab(struct i2c_algo_pcf_data *adap, const int *status)
 {
-       DEB2(printk(KERN_INFO
-               "i2c-algo-pcf.o: lost arbitration (CSR 0x%02x)\n",
-               *status));
        /*
         * Cleanup from LAB -- reset and enable ESO.
         * This resets the PCF8584; since we've lost the bus, no
@@ -88,9 +73,6 @@ static void handle_lab(struct i2c_algo_pcf_data *adap, const int *status)
        if (adap->lab_mdelay)
                mdelay(adap->lab_mdelay);
 
-       DEB2(printk(KERN_INFO
-               "i2c-algo-pcf.o: reset LAB condition (CSR 0x%02x)\n",
-               get_pcf(adap, 1)));
 }
 
 static int wait_for_bb(struct i2c_algo_pcf_data *adap)
@@ -151,9 +133,6 @@ static int pcf_init_8584 (struct i2c_algo_pcf_data *adap)
 {
        unsigned char temp;
 
-       DEB3(printk(KERN_DEBUG "i2c-algo-pcf.o: PCF state 0x%02x\n",
-                               get_pcf(adap, 1)));
-
        /* S1=0x80: S0 selected, serial interface off */
        set_pcf(adap, 1, I2C_PCF_PIN);
        /*
@@ -161,7 +140,6 @@ static int pcf_init_8584 (struct i2c_algo_pcf_data *adap)
         * PCF8584 does that when ESO is zero
         */
        if (((temp = get_pcf(adap, 1)) & 0x7f) != (0)) {
-               DEB2(printk(KERN_ERR "i2c-algo-pcf.o: PCF detection failed -- can't select S0 (0x%02x).\n", temp));
                return -ENXIO; /* definitely not PCF8584 */
        }
 
@@ -169,7 +147,6 @@ static int pcf_init_8584 (struct i2c_algo_pcf_data *adap)
        i2c_outb(adap, get_own(adap));
        /* check it's really written */
        if ((temp = i2c_inb(adap)) != get_own(adap)) {
-               DEB2(printk(KERN_ERR "i2c-algo-pcf.o: PCF detection failed -- can't set S0 (0x%02x).\n", temp));
                return -ENXIO;
        }
 
@@ -177,7 +154,6 @@ static int pcf_init_8584 (struct i2c_algo_pcf_data *adap)
        set_pcf(adap, 1, I2C_PCF_PIN | I2C_PCF_ES1);
        /* check to see S2 now selected */
        if (((temp = get_pcf(adap, 1)) & 0x7f) != I2C_PCF_ES1) {
-               DEB2(printk(KERN_ERR "i2c-algo-pcf.o: PCF detection failed -- can't select S2 (0x%02x).\n", temp));
                return -ENXIO;
        }
 
@@ -185,7 +161,6 @@ static int pcf_init_8584 (struct i2c_algo_pcf_data *adap)
        i2c_outb(adap, get_clock(adap));
        /* check it's really written, the only 5 lowest bits does matter */
        if (((temp = i2c_inb(adap)) & 0x1f) != get_clock(adap)) {
-               DEB2(printk(KERN_ERR "i2c-algo-pcf.o: PCF detection failed -- can't set S2 (0x%02x).\n", temp));
                return -ENXIO;
        }
 
@@ -194,7 +169,6 @@ static int pcf_init_8584 (struct i2c_algo_pcf_data *adap)
 
        /* check to see PCF is really idled and we can access status register */
        if ((temp = get_pcf(adap, 1)) != (I2C_PCF_PIN | I2C_PCF_BB)) {
-               DEB2(printk(KERN_ERR "i2c-algo-pcf.o: PCF detection failed -- can't select S1` (0x%02x).\n", temp));
                return -ENXIO;
        }
 
@@ -210,8 +184,6 @@ static int pcf_sendbytes(struct i2c_adapter *i2c_adap, const char *buf,
        int wrcount, status, timeout;
 
        for (wrcount=0; wrcount<count; ++wrcount) {
-               DEB2(dev_dbg(&i2c_adap->dev, "i2c_write: writing %2.2X\n",
-                               buf[wrcount] & 0xff));
                i2c_outb(adap, buf[wrcount]);
                timeout = wait_for_pin(adap, &status);
                if (timeout) {
@@ -307,8 +279,6 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap,
        /* Check for bus busy */
        timeout = wait_for_bb(adap);
        if (timeout) {
-               DEB2(printk(KERN_ERR "i2c-algo-pcf.o: "
-                           "Timeout waiting for BB in pcf_xfer\n");)
                i = -EIO;
                goto out;
        }
@@ -316,10 +286,6 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap,
        for (i = 0;ret >= 0 && i < num; i++) {
                pmsg = &msgs[i];
 
-               DEB2(printk(KERN_DEBUG "i2c-algo-pcf.o: Doing %s %d bytes to 0x%02x - %d of %d messages\n",
-                    str_read_write(pmsg->flags & I2C_M_RD),
-                    pmsg->len, pmsg->addr, i + 1, num);)
-
                ret = pcf_doAddress(adap, pmsg);
 
                /* Send START */
@@ -335,8 +301,6 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap,
                                goto out;
                        }
                        i2c_stop(adap);
-                       DEB2(printk(KERN_ERR "i2c-algo-pcf.o: Timeout waiting "
-                                   "for PIN(1) in pcf_xfer\n");)
                        i = -EREMOTEIO;
                        goto out;
                }
@@ -344,34 +308,17 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap,
                /* Check LRB (last rcvd bit - slave ack) */
                if (status & I2C_PCF_LRB) {
                        i2c_stop(adap);
-                       DEB2(printk(KERN_ERR "i2c-algo-pcf.o: No LRB(1) in pcf_xfer\n");)
                        i = -EREMOTEIO;
                        goto out;
                }
 
-               DEB3(printk(KERN_DEBUG "i2c-algo-pcf.o: Msg %d, addr=0x%x, flags=0x%x, len=%d\n",
-                           i, msgs[i].addr, msgs[i].flags, msgs[i].len);)
 
                if (pmsg->flags & I2C_M_RD) {
                        ret = pcf_readbytes(i2c_adap, pmsg->buf, pmsg->len,
                                            (i + 1 == num));
-
-                       if (ret != pmsg->len) {
-                               DEB2(printk(KERN_DEBUG "i2c-algo-pcf.o: fail: "
-                                           "only read %d bytes.\n",ret));
-                       } else {
-                               DEB2(printk(KERN_DEBUG "i2c-algo-pcf.o: read %d bytes.\n",ret));
-                       }
                } else {
                        ret = pcf_sendbytes(i2c_adap, pmsg->buf, pmsg->len,
                                            (i + 1 == num));
-
-                       if (ret != pmsg->len) {
-                               DEB2(printk(KERN_DEBUG "i2c-algo-pcf.o: fail: "
-                                           "only wrote %d bytes.\n",ret));
-                       } else {
-                               DEB2(printk(KERN_DEBUG "i2c-algo-pcf.o: wrote %d bytes.\n",ret));
-                       }
                }
        }
 
@@ -401,8 +348,6 @@ int i2c_pcf_add_bus(struct i2c_adapter *adap)
        struct i2c_algo_pcf_data *pcf_adap = adap->algo_data;
        int rval;
 
-       DEB2(dev_dbg(&adap->dev, "hw routines registered.\n"));
-
        /* register new adapter to i2c module... */
        adap->algo = &pcf_algo;
 
@@ -418,7 +363,3 @@ EXPORT_SYMBOL(i2c_pcf_add_bus);
 MODULE_AUTHOR("Hans Berglund <hb@spacetec.no>");
 MODULE_DESCRIPTION("I2C-Bus PCF8584 algorithm");
 MODULE_LICENSE("GPL");
-
-module_param(i2c_debug, int, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(i2c_debug,
-       "debug level - 0 off; 1 normal; 2,3 more verbose; 9 pcf-protocol");