Release unused key file IO lock objects

Due to off-by-one error in zonemgr_keymgmt_delete, unused key file IO
lock objects were never freed and they were kept until the server
shutdown.  Adjust the returned value by -1 to accomodate the fact that
the atomic_fetch_*() functions return the value before the operation and
not current value after the operation.

diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index 34e0ee58f816314002c81a4b8a3e828122f5b0b8..65219798e9d9f57293f856abdd0b26c4e348229e 100644 (file)
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -18929,7 +18929,7 @@ zonemgr_keymgmt_delete(dns_zonemgr_t *zmgr, dns_zone_t *zone) {
                if (dns_name_equal(kfio->name, &zone->origin)) {
                        unsigned int count;
 
-                       count = atomic_fetch_sub_relaxed(&kfio->count, 1);
+                       count = atomic_fetch_sub_relaxed(&kfio->count, 1) - 1;
                        if (count > 0) {
                                /* Keep the entry. */
                                break;