]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
FILS: Fix HE MCS field initialization
authorJouni Malinen <quic_jouni@quicinc.com>
Tue, 18 Jul 2023 13:11:08 +0000 (16:11 +0300)
committerJouni Malinen <j@w1.fi>
Tue, 18 Jul 2023 13:11:08 +0000 (16:11 +0300)
The second argument to memset() is only eight bits, so there is no point
in trying to set 0xffff values for an array of 16-bit fields. 0xff will
do the exact same thing without causing static analyzes warnings about
truncated value.

Fixes: 903e3a1e6259 ("FILS: Fix maximum NSS calculation for FD frame")
Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
src/ap/beacon.c

index 32c143a2b064e6fc0e1a7d566b4ef045e51873b7..772825d88e5a2be335a514a9cd80160ce1692d2a 100644 (file)
@@ -1450,7 +1450,7 @@ static u16 hostapd_fils_discovery_cap(struct hostapd_data *hapd)
                int i;
                u16 nss = 0, mcs[6];
 
-               os_memset(mcs, 0xffff, 6 * sizeof(u16));
+               os_memset(mcs, 0xff, 6 * sizeof(u16));
 
                if (mcs_nss_size == 4) {
                        mcs[0] = WPA_GET_LE16(&he_mcs[0]);