]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915/cx0: Use the consolidated HDMI tables
authorSuraj Kandpal <suraj.kandpal@intel.com>
Tue, 23 Dec 2025 06:34:22 +0000 (12:04 +0530)
committerSuraj Kandpal <suraj.kandpal@intel.com>
Wed, 24 Dec 2025 04:02:37 +0000 (09:32 +0530)
Use the consolidated HDMI tables before we try to compute them via
algorithm. The reason is that these are the ideal values and even
though the values calculated via the HDMI algorithm are correct but
not always ideal. This is done for C20 and already exists for C10.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Link: https://patch.msgid.link/20251223063422.1444968-1-suraj.kandpal@intel.com
drivers/gpu/drm/i915/display/intel_cx0_phy.c

index 2c87c58812da6c971b17af8b915234c2dddcd033..7288065d2461973502f62d3e683526170f34e8a0 100644 (file)
@@ -2671,15 +2671,18 @@ static int intel_c20pll_calc_state(const struct intel_crtc_state *crtc_state,
        hw_state->cx0pll.use_c10 = false;
        hw_state->cx0pll.lane_count = crtc_state->lane_count;
 
-       /* try computed C20 HDMI tables before using consolidated tables */
-       if (!is_dp)
-               /* TODO: Update SSC state for HDMI as well */
-               err = intel_c20_compute_hdmi_tmds_pll(crtc_state, &hw_state->cx0pll.c20);
-
+       /*
+        * Try the ideal C20 HDMI tables before computing them, since the calculated
+        * values, although correct, may not be optimal.
+        */
        if (err)
                err = intel_c20pll_calc_state_from_table(crtc_state, encoder,
                                                         &hw_state->cx0pll);
 
+       /* TODO: Update SSC state for HDMI as well */
+       if (!is_dp && err)
+               err = intel_c20_compute_hdmi_tmds_pll(crtc_state, &hw_state->cx0pll.c20);
+
        if (err)
                return err;