]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
dev-tools: Remove uncrustify -p
authorDavid Sommerseth <davids@openvpn.net>
Wed, 20 Apr 2022 12:13:21 +0000 (14:13 +0200)
committerGert Doering <gert@greenie.muc.de>
Thu, 21 Apr 2022 07:27:18 +0000 (09:27 +0200)
The -p option to uncrustify was providing debug information about
decisions done by uncrustify.  This was useful when debugging why
certain formatting choices.

With newer versions of uncrustify the -p option can only be used on
individual files and not a list of files.  Since still supporting this
would require a bigger rewrite of reformat-all.sh, it was chosen to
instead remove the usage of this option.  If certain behaviours needs to
be debugged, running uncrustify on individual files directly will work
fine anyhow.

Signed-off-by: David Sommerseth <davids@openvpn.net>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20220420121322.42732-2-openvpn@sf.lists.topphemmelig.net>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24120.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
dev-tools/reformat-all.sh

index dc2bfc4e9a8695e23558328ec87c2bde9b1f618c..ff126b0fdd5cb0010ec79a3b0b00952fb8499f1b 100755 (executable)
@@ -80,8 +80,8 @@ cd "$srcroot"
 
     # Kick off uncrustify
     echo
-    echo "** INFO ** Running: uncrustify -c $cfg --no-backup -l C -p debug.uncr -F $files"
-    uncrustify -c "$cfg" --no-backup -l C -p debug.uncr -F "$files" 2>&1
+    echo "** INFO ** Running: uncrustify -c $cfg --no-backup -l C -F $files"
+    uncrustify -c "$cfg" --no-backup -l C -F "$files" 2>&1
     res=$?
     echo "** INFO ** Uncrustify completed (exit code $res)"
 } | tee "${log}-1"  # Log needs to be closed here, to be processed in next block