]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
daemon/quic nit: explicitly assert !AF_UNIX docs-doq-nits-bjuv0e/deployments/9601
authorVladimír Čunát <vladimir.cunat@nic.cz>
Fri, 24 Jul 2026 09:07:22 +0000 (11:07 +0200)
committerVladimír Čunát <vladimir.cunat@nic.cz>
Fri, 24 Jul 2026 09:20:40 +0000 (11:20 +0200)
scan.coverity.com noticed this with ID 643169

daemon/quic_common.c

index 8588506b178ddd0ee6d3bf7500482e1ab4470bac..35bdcbb521bd9b6f2c889a3954d2e02a47edc70d 100644 (file)
@@ -334,6 +334,8 @@ int write_retry_packet(struct wire_buf *dest, kr_quic_table_t *table,
        uint8_t retry_token[NGTCP2_CRYPTO_MAX_RETRY_TOKENLEN2];
        uint64_t now = quic_timestamp();
 
+       if (kr_fails_assert(src_addr->sa_family != AF_UNIX))
+               return -1;  // too long addr; silence analyzers
        int ret = ngtcp2_crypto_generate_retry_token2(
                retry_token, (const uint8_t *)table->hash_secret,
                sizeof(table->hash_secret), dec_cids->version,