]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ACPI, PCI, irq: remove redundant check for null string pointer
authorColin Ian King <colin.king@canonical.com>
Tue, 5 Jan 2016 10:57:11 +0000 (10:57 +0000)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:33:55 +0000 (21:33 -0400)
[ Upstream commit 45288978859119c019eff93f0cb838a0de100bcc ]

source is decleared as a 4 byte char array in struct acpi_pci_routing_table
so !prt->source is a redundant null string pointer check. Detected with
smatch:

drivers/acpi/pci_irq.c:134 do_prt_fixups() warn: this array is probably
  non-NULL. 'prt->source'

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/acpi/pci_irq.c

index b1def411c0b89cbf7847b767063c5c2ab528e8a8..7249ba6b511f5893c98d777e05c2e23df291f008 100644 (file)
@@ -136,9 +136,6 @@ static void do_prt_fixups(struct acpi_prt_entry *entry,
                quirk = &prt_quirks[i];
 
                /* All current quirks involve link devices, not GSIs */
-               if (!prt->source)
-                       continue;
-
                if (dmi_check_system(quirk->system) &&
                    entry->id.segment == quirk->segment &&
                    entry->id.bus == quirk->bus &&