]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
detect-asn1: fix memory leak in error path
authorVictor Julien <victor@inliniac.net>
Fri, 20 Oct 2017 08:04:25 +0000 (10:04 +0200)
committerVictor Julien <victor@inliniac.net>
Tue, 24 Oct 2017 11:47:02 +0000 (13:47 +0200)
src/detect-asn1.c

index 97b44e7104bbc2eb5430c9c0db792f654ed03d67..af37546be1783bcd499b22120e1bea121b58b747 100644 (file)
@@ -262,14 +262,14 @@ static DetectAsn1Data *DetectAsn1Parse(const char *instr)
         } else {
             SCLogError(SC_ERR_INVALID_VALUE, "Malformed asn1 argument: %s",
                        asn1str);
-            return NULL;
+            goto error;
         }
         tok = strtok_r(NULL, ASN_DELIM, &saveptr);
     }
 
     fd = SCMalloc(sizeof(DetectAsn1Data));
     if (unlikely(fd == NULL)) {
-        exit(EXIT_FAILURE);
+        goto error;
     }
     memset(fd, 0x00, sizeof(DetectAsn1Data));