]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
platform/x86: alienware-wmi: printing the wrong error code
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 24 Apr 2019 09:44:18 +0000 (12:44 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 23 Sep 2019 20:12:02 +0000 (21:12 +0100)
commit 6d1f8b3d75419a8659ac916a1e9543bb3513a882 upstream.

The "out_data" variable is uninitialized at the point.  Originally, this
used to print "status" instead and that seems like the correct thing to
print.

Fixes: bc2ef884320b ("alienware-wmi: For WMAX HDMI method, introduce a way to query HDMI cable status")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/platform/x86/alienware-wmi.c

index eae2dcb209c65b7d20d20a9c1cda0e59dbc56253..f32ecc4ad878215cd2f4a88c08e39cf5946e29f5 100644 (file)
@@ -494,7 +494,7 @@ static ssize_t show_hdmi_source(struct device *dev,
                        return scnprintf(buf, PAGE_SIZE,
                                         "input [gpu] unknown\n");
        }
-       pr_err("alienware-wmi: unknown HDMI source status: %d\n", out_data);
+       pr_err("alienware-wmi: unknown HDMI source status: %u\n", status);
        return scnprintf(buf, PAGE_SIZE, "input gpu [unknown]\n");
 }