]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpio: tps65219: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 2 Jul 2025 09:14:12 +0000 (11:14 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 7 Jul 2025 07:45:30 +0000 (09:45 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Link: https://lore.kernel.org/r/20250702-gpiochip-set-rv-gpio-round3-v1-11-0d23be74f71d@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-tps65219.c

index 526640c39a11faf7837847d7eccf0aa33d482ffb..630cb41e77a4ef212305e710e988999c98cfbe66 100644 (file)
@@ -65,10 +65,9 @@ static int tps65219_gpio_get(struct gpio_chip *gc, unsigned int offset)
        return ret;
 }
 
-static void tps65219_gpio_set(struct gpio_chip *gc, unsigned int offset, int value)
+static int tps65219_gpio_set(struct gpio_chip *gc, unsigned int offset, int value)
 {
        struct tps65219_gpio *gpio = gpiochip_get_data(gc);
-       struct device *dev = gpio->tps->dev;
        int v, mask, bit;
 
        bit = (offset == TPS65219_GPIO0_IDX) ? TPS65219_GPIO0_OFFSET : offset - 1;
@@ -76,8 +75,8 @@ static void tps65219_gpio_set(struct gpio_chip *gc, unsigned int offset, int val
        mask = BIT(bit);
        v = value ? mask : 0;
 
-       if (regmap_update_bits(gpio->tps->regmap, TPS65219_REG_GENERAL_CONFIG, mask, v))
-               dev_err(dev, "GPIO%d, set to value %d failed.\n", offset, value);
+       return regmap_update_bits(gpio->tps->regmap,
+                                 TPS65219_REG_GENERAL_CONFIG, mask, v);
 }
 
 static int tps65219_gpio_change_direction(struct gpio_chip *gc, unsigned int offset,
@@ -147,7 +146,7 @@ static const struct gpio_chip tps65219_template_chip = {
        .direction_input        = tps65219_gpio_direction_input,
        .direction_output       = tps65219_gpio_direction_output,
        .get                    = tps65219_gpio_get,
-       .set                    = tps65219_gpio_set,
+       .set_rv                 = tps65219_gpio_set,
        .base                   = -1,
        .ngpio                  = 3,
        .can_sleep              = true,