]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
net: fec_mxc: rewrite fallback MDIO Bus allocation
authorMarkus Niebel <Markus.Niebel@ew.tq-group.com>
Fri, 21 Nov 2025 17:34:45 +0000 (18:34 +0100)
committerFabio Estevam <festevam@nabladev.com>
Sat, 29 Nov 2025 20:06:26 +0000 (17:06 -0300)
The code should only be executed if MDIO bus is not assigned.
Otherwise the already assigned / allocated bus will be overwritten.
Add condition check and simplify the code to make it more readable.

Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Signed-off-by: Alexander Feilke <alexander.feilke@ew.tq-group.com>
drivers/net/fec_mxc.c

index 69a76e879b128858c121d24f26503ee7244b8fff..af6a799e167d2dd5221a5df77196fe29aa8f5b6c 100644 (file)
@@ -1373,14 +1373,18 @@ static int fecmxc_probe(struct udevice *dev)
        if (!bus)
                bus = fec_get_miibus(dev, (ulong)priv->eth, dev_seq(dev));
 #else
+       if (!bus) {
+               ulong regs = (ulong)priv->eth;
 
-       dm_mii_bus = false;
-#ifdef CONFIG_FEC_MXC_MDIO_BASE
-       bus = fec_get_miibus(dev, (ulong)CONFIG_FEC_MXC_MDIO_BASE, dev_seq(dev));
-#else
-       bus = fec_get_miibus(dev, (ulong)priv->eth, dev_seq(dev));
+               dm_mii_bus = false;
+
+#if defined(CONFIG_FEC_MXC_MDIO_BASE)
+               regs = CONFIG_FEC_MXC_MDIO_BASE;
 #endif
 
+               bus = fec_get_miibus(dev, regs, dev_seq(dev));
+       }
+
 #endif /* CONFIG_DM_ETH_PHY */
        if (!bus) {
                ret = -ENOMEM;