]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: hda: Remove redundant pm_runtime_mark_last_busy() calls
authorSakari Ailus <sakari.ailus@linux.intel.com>
Fri, 4 Jul 2025 07:54:55 +0000 (10:54 +0300)
committerTakashi Iwai <tiwai@suse.de>
Sun, 6 Jul 2025 08:25:31 +0000 (10:25 +0200)
pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
pm_runtime_mark_last_busy().

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Link: https://patch.msgid.link/20250704075455.3222438-1-sakari.ailus@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/hda/hdac_device.c
sound/pci/hda/cs35l41_hda.c
sound/pci/hda/cs35l56_hda.c
sound/pci/hda/tas2781_hda_i2c.c
sound/pci/hda/tas2781_hda_spi.c

index 0053831eed2dec951945400d072cde6105d44b29..a02dce5f6a8897d044254457337ad55717cc97c7 100644 (file)
@@ -581,7 +581,6 @@ int snd_hdac_power_down(struct hdac_device *codec)
 {
        struct device *dev = &codec->dev;
 
-       pm_runtime_mark_last_busy(dev);
        return pm_runtime_put_autosuspend(dev);
 }
 EXPORT_SYMBOL_GPL(snd_hdac_power_down);
index 6155a8d2ef4e85f8a91745308c9304b69cd63f08..2d7ee121a7fd4a994257b3fae3511778aa02446c 100644 (file)
@@ -836,7 +836,6 @@ static void cs35l41_hda_playback_hook(struct device *dev, int action)
                 * Playback must be finished for all amps before we start runtime suspend.
                 * This ensures no amps are playing back when we start putting them to sleep.
                 */
-               pm_runtime_mark_last_busy(dev);
                pm_runtime_put_autosuspend(dev);
                break;
        default:
@@ -1284,7 +1283,6 @@ static void cs35l41_fw_load_work(struct work_struct *work)
        cs35l41->fw_request_ongoing = false;
        mutex_unlock(&cs35l41->fw_mutex);
 
-       pm_runtime_mark_last_busy(cs35l41->dev);
        pm_runtime_put_autosuspend(cs35l41->dev);
 }
 
@@ -1515,7 +1513,6 @@ static int cs35l41_hda_bind(struct device *dev, struct device *master, void *mas
                dev_warn(dev, "Unable to create device link\n");
        unlock_system_sleep(sleep_flags);
 
-       pm_runtime_mark_last_busy(dev);
        pm_runtime_put_autosuspend(dev);
 
        dev_info(cs35l41->dev,
@@ -2036,7 +2033,6 @@ int cs35l41_hda_probe(struct device *dev, const char *device_name, int id, int i
 
        pm_runtime_set_autosuspend_delay(cs35l41->dev, 3000);
        pm_runtime_use_autosuspend(cs35l41->dev);
-       pm_runtime_mark_last_busy(cs35l41->dev);
        pm_runtime_set_active(cs35l41->dev);
        pm_runtime_get_noresume(cs35l41->dev);
        pm_runtime_enable(cs35l41->dev);
index eedd8fdd3b8beb6b3ee326396b60ed7a2c40ae09..e8b4995118bbff8e5d5f3ffd5866d98a3784126c 100644 (file)
@@ -89,7 +89,6 @@ static void cs35l56_hda_pause(struct cs35l56_hda *cs35l56)
                          BIT(CS35L56_ASP_TX1_EN_SHIFT) | BIT(CS35L56_ASP_TX2_EN_SHIFT) |
                          BIT(CS35L56_ASP_TX3_EN_SHIFT) | BIT(CS35L56_ASP_TX4_EN_SHIFT));
 
-       pm_runtime_mark_last_busy(cs35l56->base.dev);
        pm_runtime_put_autosuspend(cs35l56->base.dev);
 }
 
index 530c2266ab3bb5911e10b6ff1bcb7b5347a8f722..b7ee22840d78935edfdedbb30771ee0b9b0f3be1 100644 (file)
@@ -157,7 +157,6 @@ static void tas2781_hda_playback_hook(struct device *dev, int action)
                tas_hda->priv->playback_started = false;
                mutex_unlock(&tas_hda->priv->codec_lock);
 
-               pm_runtime_mark_last_busy(dev);
                pm_runtime_put_autosuspend(dev);
                break;
        default:
@@ -483,7 +482,6 @@ static void tasdev_fw_ready(const struct firmware *fmw, void *context)
 out:
        mutex_unlock(&tas_hda->priv->codec_lock);
        release_firmware(fmw);
-       pm_runtime_mark_last_busy(tas_hda->dev);
        pm_runtime_put_autosuspend(tas_hda->dev);
 }
 
@@ -526,7 +524,6 @@ static int tas2781_hda_bind(struct device *dev, struct device *master,
        if (!ret)
                comp->playback_hook = tas2781_hda_playback_hook;
 
-       pm_runtime_mark_last_busy(dev);
        pm_runtime_put_autosuspend(dev);
 
        return ret;
index 5c03e9d2283a1c246137a6bbb62e32cc71246e18..c4b9a3c1a7f0768fa42bc560530d139bed5b7a0a 100644 (file)
@@ -400,7 +400,6 @@ static void tas2781_hda_playback_hook(struct device *dev, int action)
                guard(mutex)(&tas_priv->codec_lock);
                if (tas_priv->fw_state == TASDEVICE_DSP_FW_ALL_OK)
                        tasdevice_tuning_switch(tas_priv, 1);
-               pm_runtime_mark_last_busy(dev);
                pm_runtime_put_autosuspend(dev);
        }
 }
@@ -698,7 +697,6 @@ static void tasdev_fw_ready(const struct firmware *fmw, void *context)
        tas2781_save_calibration(tas_hda);
 out:
        release_firmware(fmw);
-       pm_runtime_mark_last_busy(tas_hda->priv->dev);
        pm_runtime_put_autosuspend(tas_hda->priv->dev);
 }
 
@@ -731,7 +729,6 @@ static int tas2781_hda_bind(struct device *dev, struct device *master,
        if (!ret)
                comp->playback_hook = tas2781_hda_playback_hook;
 
-       pm_runtime_mark_last_busy(dev);
        pm_runtime_put_autosuspend(dev);
 
        return ret;
@@ -816,7 +813,6 @@ static int tas2781_hda_spi_probe(struct spi_device *spi)
 
        pm_runtime_set_autosuspend_delay(tas_priv->dev, 3000);
        pm_runtime_use_autosuspend(tas_priv->dev);
-       pm_runtime_mark_last_busy(tas_priv->dev);
        pm_runtime_set_active(tas_priv->dev);
        pm_runtime_get_noresume(tas_priv->dev);
        pm_runtime_enable(tas_priv->dev);