]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
fpga: dfl-afu: validate DMA mapping length in afu_dma_map_region()
authorSebastian Alba Vives <sebasjosue84@gmail.com>
Mon, 18 May 2026 19:07:41 +0000 (13:07 -0600)
committerXu Yilun <yilun.xu@linux.intel.com>
Mon, 1 Jun 2026 04:29:13 +0000 (12:29 +0800)
afu_ioctl_dma_map() accepts a 64-bit length from userspace via
DFL_FPGA_PORT_DMA_MAP ioctl without an upper bound check. The value
is passed to afu_dma_pin_pages() where npages is derived as
length >> PAGE_SHIFT and passed to pin_user_pages_fast() which takes
int nr_pages, causing implicit truncation if length is very large.

Validate map.length at the ioctl entry point before calling
afu_dma_map_region(), rejecting values whose page count exceeds
INT_MAX.

Fixes: fa8dda1edef9 ("fpga: dfl: afu: add DFL_FPGA_PORT_DMA_MAP/UNMAP ioctls support")
Cc: stable@vger.kernel.org
Signed-off-by: Sebastian Alba Vives <sebasjosue84@gmail.com>
Reviewed-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20260518190742.61426-3-sebasjosue84@gmail.com
Signed-off-by: Xu Yilun <yilun.xu@linux.intel.com>
drivers/fpga/dfl-afu-main.c

index 3bf8e7338dbefd5460fac5ad3dc734de87d06a06..097a97eeea66c20c350064ddbc50d23e2470e2e9 100644 (file)
@@ -723,6 +723,9 @@ afu_ioctl_dma_map(struct dfl_feature_dev_data *fdata, void __user *arg)
        if (map.argsz < minsz || map.flags)
                return -EINVAL;
 
+       if (map.length >> PAGE_SHIFT > (u64)INT_MAX)
+               return -EINVAL;
+
        ret = afu_dma_map_region(fdata, map.user_addr, map.length, &map.iova);
        if (ret)
                return ret;