bhyve: do not use deprecated IOAPIC option

The '-I' flag for enabling IOAPIC was deprecated long ago in bhyve:

https://cgit.freebsd.org/src/commit/?id=a1a4cbea587a6e201e07dc121268f3e559e2969f

And IOAPIC is provided unconditionally since then. As no supported
FreeBSD versions require that now, simply drop this flag.

Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c
index ff079da9ef8fa0236ef9fbcaf1212aee0033eb03..54e9185e8a9210d35ec9fa018aaec5e4b66992e9 100644 (file)
--- a/src/bhyve/bhyve_command.c
+++ b/src/bhyve/bhyve_command.c
@@ -951,8 +951,6 @@ virBhyveProcessBuildBhyveCmd(struct _bhyveConn *driver, virDomainDef *def,
     /* Options */
     if (def->features[VIR_DOMAIN_FEATURE_ACPI] == VIR_TRISTATE_SWITCH_ON)
         virCommandAddArg(cmd, "-A"); /* Create an ACPI table */
-    if (def->features[VIR_DOMAIN_FEATURE_APIC] == VIR_TRISTATE_SWITCH_ON)
-        virCommandAddArg(cmd, "-I"); /* Present ioapic to the guest */
     if (def->features[VIR_DOMAIN_FEATURE_MSRS] == VIR_TRISTATE_SWITCH_ON) {
         if (def->msrs_features[VIR_DOMAIN_MSRS_UNKNOWN] == VIR_DOMAIN_MSRS_UNKNOWN_IGNORE)
             virCommandAddArg(cmd, "-w");

diff --git a/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-acpiapic.args b/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-acpiapic.args
index 146e3c6eee601d061fc39824387ebf74ec79b7db..a3d521069d522a7e1e0570829c840abbce8d513b 100644 (file)
--- a/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-acpiapic.args
+++ b/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-acpiapic.args
@@ -2,7 +2,6 @@ bhyve \
 -c 1 \
 -m 214 \
 -A \
--I \
 -u \
 -H \
 -P \