]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: wss: Use safer strscpy() instead of strcpy()
authorTakashi Iwai <tiwai@suse.de>
Thu, 10 Jul 2025 10:06:20 +0000 (12:06 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 11 Jul 2025 07:53:16 +0000 (09:53 +0200)
Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250710100727.22653-39-tiwai@suse.de
sound/isa/wss/wss_lib.c

index 9c655789574d0a13ebbd41fac5bdc337e1995921..1b6a80021d182967e221e378e6c620310f2ade85 100644 (file)
@@ -1865,7 +1865,7 @@ int snd_wss_pcm(struct snd_wss *chip, int device)
                pcm->info_flags |= SNDRV_PCM_INFO_HALF_DUPLEX;
        if (chip->hardware != WSS_HW_INTERWAVE)
                pcm->info_flags |= SNDRV_PCM_INFO_JOINT_DUPLEX;
-       strcpy(pcm->name, snd_wss_chip_id(chip));
+       strscpy(pcm->name, snd_wss_chip_id(chip));
 
        snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_DEV, chip->card->dev,
                                       64*1024, chip->dma1 > 3 || chip->dma2 > 3 ? 128*1024 : 64*1024);
@@ -1896,7 +1896,7 @@ int snd_wss_timer(struct snd_wss *chip, int device)
        err = snd_timer_new(chip->card, "CS4231", &tid, &timer);
        if (err < 0)
                return err;
-       strcpy(timer->name, snd_wss_chip_id(chip));
+       strscpy(timer->name, snd_wss_chip_id(chip));
        timer->private_data = chip;
        timer->private_free = snd_wss_timer_free;
        timer->hw = snd_wss_timer_table;
@@ -2176,7 +2176,7 @@ int snd_wss_mixer(struct snd_wss *chip)
 
        card = chip->card;
 
-       strcpy(card->mixername, chip->pcm->name);
+       strscpy(card->mixername, chip->pcm->name);
 
        /* Use only the first 11 entries on AD1848 */
        if (chip->hardware & WSS_HW_AD1848_MASK)