]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
clk: milbeaut: convert from divider_ro_round_rate() to divider_ro_determine_rate()
authorBrian Masney <bmasney@redhat.com>
Thu, 8 Jan 2026 21:16:28 +0000 (16:16 -0500)
committerBrian Masney <bmasney@redhat.com>
Thu, 22 Jan 2026 15:48:25 +0000 (10:48 -0500)
The divider_ro_round_rate() function is now deprecated, so let's migrate
to divider_ro_determine_rate() instead so that this deprecated API can
be removed.

Note that when the main function itself was migrated to use
determine_rate, this was mistakenly converted to:

    req->rate = divider_round_rate(...)

This is invalid in the case when an error occurs since it can set the
rate to a negative value.

Fixes: fe67c682f91c ("clk: milbeaut: convert from divider_round_rate() to divider_determine_rate()")
Signed-off-by: Brian Masney <bmasney@redhat.com>
drivers/clk/clk-milbeaut.c

index b4f9b7143eaa658a7f2a14ff3cc9d91d8aa071c6..4e3790b7fc9064484c20a068d0315b8fc8241290 100644 (file)
@@ -398,13 +398,9 @@ static int m10v_clk_divider_determine_rate(struct clk_hw *hw,
                val = readl(divider->reg) >> divider->shift;
                val &= clk_div_mask(divider->width);
 
-               req->rate = divider_ro_round_rate(hw, req->rate,
-                                                 &req->best_parent_rate,
-                                                 divider->table,
-                                                 divider->width,
-                                                 divider->flags, val);
-
-               return 0;
+               return divider_ro_determine_rate(hw, req, divider->table,
+                                                divider->width, divider->flags,
+                                                val);
        }
 
        req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate,