]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Input: pcf50633-input - remove the driver
authorDr. David Alan Gilbert <linux@treblig.org>
Sun, 29 Jun 2025 21:28:20 +0000 (22:28 +0100)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 30 Jun 2025 05:04:24 +0000 (22:04 -0700)
The pcf50633 was used as part of the OpenMoko devices but the support
for its main chip was recently removed in: commit 61b7f8920b17 ("ARM:
s3c: remove all s3c24xx support")

Remove the input driver.

This was originally posted as a set of pcf50633 removals in March,
and is the only major component that hasn't been picked up.
https://lore.kernel.org/all/20250311014959.743322-1-linux@treblig.org/

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Link: https://lore.kernel.org/r/20250629212820.319584-1-linux@treblig.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/Kconfig
drivers/input/misc/Makefile
drivers/input/misc/pcf50633-input.c [deleted file]

index f5496ca0c0d2bfcb7968503ccd1844ff43bbc1c0..0fb21c99a5e3d1230d7f40f99e0c2d360bbe80e8 100644 (file)
@@ -584,13 +584,6 @@ config INPUT_PALMAS_PWRBUTTON
          To compile this driver as a module, choose M here. The module will
          be called palmas_pwrbutton.
 
-config INPUT_PCF50633_PMU
-       tristate "PCF50633 PMU events"
-       depends on MFD_PCF50633
-       help
-        Say Y to include support for delivering  PMU events via  input
-        layer on NXP PCF50633.
-
 config INPUT_PCF8574
        tristate "PCF8574 Keypad input device"
        depends on I2C
index 6d91804d0a6f761a094e6c380f878f74c3054d63..d468c8140b93da5bb537e8a3baea2b90e7bb4229 100644 (file)
@@ -59,7 +59,6 @@ obj-$(CONFIG_INPUT_MC13783_PWRBUTTON) += mc13783-pwrbutton.o
 obj-$(CONFIG_INPUT_MMA8450)            += mma8450.o
 obj-$(CONFIG_INPUT_PALMAS_PWRBUTTON)   += palmas-pwrbutton.o
 obj-$(CONFIG_INPUT_PCAP)               += pcap_keys.o
-obj-$(CONFIG_INPUT_PCF50633_PMU)       += pcf50633-input.o
 obj-$(CONFIG_INPUT_PCF8574)            += pcf8574_keypad.o
 obj-$(CONFIG_INPUT_PCSPKR)             += pcspkr.o
 obj-$(CONFIG_INPUT_PM8941_PWRKEY)      += pm8941-pwrkey.o
diff --git a/drivers/input/misc/pcf50633-input.c b/drivers/input/misc/pcf50633-input.c
deleted file mode 100644 (file)
index 6d046e2..0000000
+++ /dev/null
@@ -1,113 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
-/* NXP PCF50633 Input Driver
- *
- * (C) 2006-2008 by Openmoko, Inc.
- * Author: Balaji Rao <balajirrao@openmoko.org>
- * All rights reserved.
- *
- * Broken down from monstrous PCF50633 driver mainly by
- * Harald Welte, Andy Green and Werner Almesberger
- */
-
-#include <linux/kernel.h>
-#include <linux/module.h>
-#include <linux/device.h>
-#include <linux/platform_device.h>
-#include <linux/input.h>
-#include <linux/slab.h>
-
-#include <linux/mfd/pcf50633/core.h>
-
-#define PCF50633_OOCSTAT_ONKEY 0x01
-#define PCF50633_REG_OOCSTAT   0x12
-#define PCF50633_REG_OOCMODE   0x10
-
-struct pcf50633_input {
-       struct pcf50633 *pcf;
-       struct input_dev *input_dev;
-};
-
-static void
-pcf50633_input_irq(int irq, void *data)
-{
-       struct pcf50633_input *input;
-       int onkey_released;
-
-       input = data;
-
-       /* We report only one event depending on the key press status */
-       onkey_released = pcf50633_reg_read(input->pcf, PCF50633_REG_OOCSTAT)
-                                               & PCF50633_OOCSTAT_ONKEY;
-
-       if (irq == PCF50633_IRQ_ONKEYF && !onkey_released)
-               input_report_key(input->input_dev, KEY_POWER, 1);
-       else if (irq == PCF50633_IRQ_ONKEYR && onkey_released)
-               input_report_key(input->input_dev, KEY_POWER, 0);
-
-       input_sync(input->input_dev);
-}
-
-static int pcf50633_input_probe(struct platform_device *pdev)
-{
-       struct pcf50633_input *input;
-       struct input_dev *input_dev;
-       int ret;
-
-
-       input = kzalloc(sizeof(*input), GFP_KERNEL);
-       if (!input)
-               return -ENOMEM;
-
-       input_dev = input_allocate_device();
-       if (!input_dev) {
-               kfree(input);
-               return -ENOMEM;
-       }
-
-       platform_set_drvdata(pdev, input);
-       input->pcf = dev_to_pcf50633(pdev->dev.parent);
-       input->input_dev = input_dev;
-
-       input_dev->name = "PCF50633 PMU events";
-       input_dev->id.bustype = BUS_I2C;
-       input_dev->evbit[0] = BIT(EV_KEY) | BIT(EV_PWR);
-       set_bit(KEY_POWER, input_dev->keybit);
-
-       ret = input_register_device(input_dev);
-       if (ret) {
-               input_free_device(input_dev);
-               kfree(input);
-               return ret;
-       }
-       pcf50633_register_irq(input->pcf, PCF50633_IRQ_ONKEYR,
-                               pcf50633_input_irq, input);
-       pcf50633_register_irq(input->pcf, PCF50633_IRQ_ONKEYF,
-                               pcf50633_input_irq, input);
-
-       return 0;
-}
-
-static void pcf50633_input_remove(struct platform_device *pdev)
-{
-       struct pcf50633_input *input  = platform_get_drvdata(pdev);
-
-       pcf50633_free_irq(input->pcf, PCF50633_IRQ_ONKEYR);
-       pcf50633_free_irq(input->pcf, PCF50633_IRQ_ONKEYF);
-
-       input_unregister_device(input->input_dev);
-       kfree(input);
-}
-
-static struct platform_driver pcf50633_input_driver = {
-       .driver = {
-               .name = "pcf50633-input",
-       },
-       .probe = pcf50633_input_probe,
-       .remove = pcf50633_input_remove,
-};
-module_platform_driver(pcf50633_input_driver);
-
-MODULE_AUTHOR("Balaji Rao <balajirrao@openmoko.org>");
-MODULE_DESCRIPTION("PCF50633 input driver");
-MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:pcf50633-input");