s3/libsmb: clang: Fix '2nd func call argument is uninitalized value'

Fixes:

source3/libsmb/clireadwrite.c:805:2: warning: 2nd function call argument is an uninitialized value <--[clang]
        memcpy(state->buf, buf, received);
        ^                  ~~~

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

diff --git a/source3/libsmb/clireadwrite.c b/source3/libsmb/clireadwrite.c
index 5ee202ebf4ec361d77158f4d399205d884626b9d..082febf49ccd8b2d04ba2ccb5322616a512713c5 100644 (file)
--- a/source3/libsmb/clireadwrite.c
+++ b/source3/libsmb/clireadwrite.c
@@ -781,7 +781,7 @@ static void cli_read_done(struct tevent_req *subreq)
                req, struct cli_read_state);
        NTSTATUS status;
        ssize_t received;
-       uint8_t *buf;
+       uint8_t *buf = NULL;
 
        if (smbXcli_conn_protocol(state->cli->conn) >= PROTOCOL_SMB2_02) {
                status = cli_smb2_read_recv(subreq, &received, &buf);
@@ -796,7 +796,7 @@ static void cli_read_done(struct tevent_req *subreq)
        if (tevent_req_nterror(req, status)) {
                return;
        }
-       if ((received < 0) || (received > state->buflen)) {
+       if ((buf == NULL) || (received < 0) || (received > state->buflen)) {
                state->received = 0;
                tevent_req_nterror(req, NT_STATUS_UNEXPECTED_IO_ERROR);
                return;