]> git.ipfire.org Git - thirdparty/bird.git/commitdiff
Babel: Fix bug in iface reconfiguration
authorOndrej Zajicek (work) <santiago@crfreenet.org>
Sun, 27 Feb 2022 02:10:38 +0000 (03:10 +0100)
committerOndrej Zajicek (work) <santiago@crfreenet.org>
Sun, 27 Feb 2022 02:10:38 +0000 (03:10 +0100)
A recent change in Babel causes ifaces to disappear after
reconfiguration. The patch fixes that.

Thanks to Johannes Kimmel for an insightful bugreport.

proto/babel/babel.c

index e43818f504a5375cd7c272df09a93ddb1b4aed07..174fc9e266548a5a332725cd15373524351fcf55 100644 (file)
@@ -1899,7 +1899,7 @@ babel_reconfigure_ifaces(struct babel_proto *p, struct babel_config *cf)
     struct babel_iface *ifa = babel_find_iface(p, iface);
     struct babel_iface_config *ic = (void *) iface_patt_find(&cf->iface_list, iface, NULL);
 
-    if (ic && iface_is_valid(p, iface))
+    if (ic && !iface_is_valid(p, iface))
       ic = NULL;
 
     if (ifa && ic)