Gracefully handle invalid queries

Prevent custom servers based on asyncserver.py from exiting prematurely
due to unhandled exceptions raised as a result of attempting to parse
invalid queries sent by clients.

diff --git a/bin/tests/system/isctest/asyncserver.py b/bin/tests/system/isctest/asyncserver.py
index 33ca5ad6911036691d7bb9b69d0be31c4000a289..fb5f2c21c34da50ca3dd178f658c4b00948583de 100644 (file)
--- a/bin/tests/system/isctest/asyncserver.py
+++ b/bin/tests/system/isctest/asyncserver.py
@@ -728,7 +728,11 @@ class AsyncDnsServer(AsyncServer):
         """
         Yield wire data to send as a response over the established transport.
         """
-        query = dns.message.from_wire(wire)
+        try:
+            query = dns.message.from_wire(wire)
+        except dns.exception.DNSException as exc:
+            logging.error("Invalid query from %s (%s): %s", peer, wire.hex(), exc)
+            return
         response_stub = dns.message.make_response(query)
         qctx = QueryContext(query, response_stub, peer, protocol)
         self._log_query(qctx, peer, protocol)