]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
cdx: controller: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 2 May 2025 06:20:34 +0000 (08:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 1 Jul 2025 10:18:07 +0000 (12:18 +0200)
Simplify printing probe failures and handling deferred probe with
dev_err_probe().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Nikhil Agarwal <nikhil.agarwal@amd.com>
Link: https://lore.kernel.org/r/20250502-cdx-clean-v3-2-6aaa5b369fc5@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/cdx/controller/cdx_controller.c

index d623f9c7517a86c06082c0db348688e7f33b7be6..3df35833f0e0a994af0606eee0dc1dfc9c7c22f9 100644 (file)
@@ -195,15 +195,13 @@ static int xlnx_cdx_probe(struct platform_device *pdev)
        /* Create MSI domain */
        cdx->msi_domain = cdx_msi_domain_init(&pdev->dev);
        if (!cdx->msi_domain) {
-               dev_err(&pdev->dev, "cdx_msi_domain_init() failed");
-               ret = -ENODEV;
+               ret = dev_err_probe(&pdev->dev, -ENODEV, "cdx_msi_domain_init() failed");
                goto cdx_msi_fail;
        }
 
        ret = cdx_setup_rpmsg(pdev);
        if (ret) {
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "Failed to register CDX RPMsg transport\n");
+               dev_err_probe(&pdev->dev, ret, "Failed to register CDX RPMsg transport\n");
                goto cdx_rpmsg_fail;
        }