]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
RDMA/cxgb4: Delete an unnecessary check before kfree() in c4iw_rdev_open()
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 10 Jun 2025 12:14:09 +0000 (14:14 +0200)
committerLeon Romanovsky <leon@kernel.org>
Thu, 12 Jun 2025 08:39:12 +0000 (04:39 -0400)
It can be known that the function “kfree” performs a null pointer check
for its input parameter.
It is therefore not needed to repeat such a check before its call.

Thus remove a redundant pointer check.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://patch.msgid.link/cdc577a5-cebd-404a-b762-cc6fee0870dc@web.de
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/cxgb4/device.c

index 034b85c4225555874c1cf4be09b07d3cb75bbff3..b67747ae6a6889018126aecbcccf5fd6d39807bf 100644 (file)
@@ -905,8 +905,7 @@ static int c4iw_rdev_open(struct c4iw_rdev *rdev)
 
        return 0;
 err_free_status_page_and_wr_log:
-       if (c4iw_wr_log && rdev->wr_log)
-               kfree(rdev->wr_log);
+       kfree(rdev->wr_log);
        free_page((unsigned long)rdev->status_page);
 destroy_ocqp_pool:
        c4iw_ocqp_pool_destroy(rdev);