CID 1009579: Check return status of X509_add_ext()

bk: 52118a55HBLFBDXN8jxlpsTR45dYVg

diff --git a/ChangeLog b/ChangeLog
index d2d999c32808e4fc2e5f09d3e7e9d731e5d9e2c7..7469a79482e4b9acc418bc5349c703cc815e4319 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,4 @@
+* CID 1009579: Check return status of X509_add_ext().
 * [2085] Fix root distance and root dispersion calculations.
 (4.2.7p384) 2013/08/18 Released by Harlan Stenn <stenn@ntp.org>
 * [Bug 2450] --version has bogus short option.

diff --git a/ntpd/ntp_crypto.c b/ntpd/ntp_crypto.c
index 6c6734763efaf36841abe7f090a4da59e4ba30f2..f4d1f496ab8fec34501d09977a3ee69ea2dd4448 100644 (file)
--- a/ntpd/ntp_crypto.c
+++ b/ntpd/ntp_crypto.c
@@ -2992,7 +2992,7 @@ cert_sign(
        temp = X509_get_ext_count(req);
        for (i = 0; i < temp; i++) {
                ext = X509_get_ext(req, i);
-               X509_add_ext(cert, ext, -1);
+               INSIST(X509_add_ext(cert, ext, -1));
        }
        X509_free(req);