]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/bridge: parade-ps8640: Fix regulator supply order
authorChen-Yu Tsai <wenst@chromium.org>
Thu, 21 Jul 2022 09:22:58 +0000 (17:22 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2022 07:57:17 +0000 (09:57 +0200)
[ Upstream commit fc94224c2e0ae8d83ac511a3ef4962178505469d ]

The datasheet says that VDD12 must be enabled and at full voltage before
VDD33 is enabled.

Reorder the bulk regulator supply names so that VDD12 is enabled before
VDD33. Any enable ramp delays should be handled by setting proper
constraints on the regulators.

Fixes: bc1aee7fc8f0 ("drm/bridge: Add I2C based driver for ps8640 bridge")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220721092258.3397461-1-wenst@chromium.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/bridge/parade-ps8640.c

index edb939b14c04ed6afc8afa9083fb3d9b46af4ecf..38dcc606b4992c1315065d1c8e215d692161ee3b 100644 (file)
@@ -596,8 +596,8 @@ static int ps8640_probe(struct i2c_client *client)
        if (!ps_bridge)
                return -ENOMEM;
 
-       ps_bridge->supplies[0].supply = "vdd33";
-       ps_bridge->supplies[1].supply = "vdd12";
+       ps_bridge->supplies[0].supply = "vdd12";
+       ps_bridge->supplies[1].supply = "vdd33";
        ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ps_bridge->supplies),
                                      ps_bridge->supplies);
        if (ret)